PHPORM-171 Set timestamps when using createOrFirst
#2905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
changed the title
createOrFirst
GromNaN
commented
Apr 23, 2024
Comment on lines
+207
to
+211
|
|
||
| /* @see \Illuminate\Database\Eloquent\Model::performInsert */ | ||
| if ($instance->usesTimestamps()) { | ||
| $instance->updateTimestamps(); | ||
| } |
There was a problem hiding this comment.
This was referenced Apr 24, 2024
GromNaN
force-pushed
the
PHPORM-171
branch
2 times, most recently
from
c5bedea to
ed949b9
Compare
jmikola
reviewed
Apr 24, 2024
| $user1 = User::createOrFirst(['email' => '[email protected]']); | ||
|
|
||
| $this->assertSame('[email protected]', $user1->email); | ||
| $this->assertNull($user1->name); | ||
| $this->assertTrue($user1->wasRecentlyCreated); | ||
| $this->assertEquals($createdAt, $user1->created_at->getTimestamp()); |
There was a problem hiding this comment.
Should this use a comparison to assert that the created_at and updated_at fields are greater than or equal to the previously calculated current time?
I don't see anything in the PR that would guarantee the entire test completes within a single timestamp.
There was a problem hiding this comment.
Carbon::setTestNow freezes the clock, so that the date point that is used to populate create_at is the one that is set.
jmikola
approved these changes
Apr 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PHPORM-171
Issue reported by @nicohell #2720 (comment)
Checklist